Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fetch new rows only once when multiple models are changed in one cycle #16101

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[DataGridPro] Fetch new rows only once when multiple models are changed in one cycle #16101

wants to merge 15 commits into from
+144 −48

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Jan 8, 2025

Extracted from the work in #15378
It is also needed in #15548

This way, it will be easier to cherry pick it to v7

@arminmeh arminmeh added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x feature: Server integration Better integration with backends, e.g. data source labels Jan 8, 2025
@mui-bot
Copy link

mui-bot commented Jan 8, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16101--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a12dc93

@arminmeh arminmeh marked this pull request as draft January 8, 2025 16:30
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@arminmeh arminmeh force-pushed the debouce-fetch-rows branch from 679f628 to d5c8643 Compare January 9, 2025 12:40
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
@arminmeh arminmeh force-pushed the debouce-fetch-rows branch from d5c8643 to 1251740 Compare January 9, 2025 19:34
@arminmeh arminmeh marked this pull request as ready for review January 10, 2025 13:27
@arminmeh arminmeh requested a review from a team January 10, 2025 13:27
@arminmeh
Copy link
Contributor Author

It looks like that setProps helper does not play nicely if you have debounce.
I could see in the console that the new fetch call is being made, but the callCount would not update in the spy. Switching to apiRef helped.

@cherniavskii
Copy link
Member

It looks like that setProps helper does not play nicely if you have debounce.

That's super weird. This might be a symptom of an issue on our side. I'll take a look at it to better understand what's going on there.

cherniavskii
cherniavskii reviewed Jan 10, 2025
View reviewed changes
packages/x-data-grid-pro/src/tests/dataSource.DataGridPro.test.tsx
const { fetchRows } = mockServer;

// Reuse the same stub between rerenders to properly count the calls
fetchRowsSpy = useLazyRef(() => stub()).current;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason setProps was causing issues is that fetchRowsSpy was recreated on each TestDataSource rerender 😅
I've fixed that and reverted back the usage of setProps.
Some tests will probably fail though, but IMO in that case there's something wrong with the test or implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Server integration Better integration with backends, e.g. data source needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arminmeh @mui-bot @cherniavskii